Debian bug report logs - #1651
lastcomm has bug with 8 character user names (patch enclosed)

Message received at debian-bugs-done:

From qed.econ.queensu.ca!edd Fri Oct 13 09:21:07 1995
Return-Path: <edd@qed.econ.queensu.ca>
Received: from pixar.com by mongo.pixar.com with smtp
	(Smail3.1.28.1 #15) id m0t3mr5-000BbXC; Fri, 13 Oct 95 09:21 PDT
Received: from post.QueensU.CA (knot.QueensU.CA) by pixar.com with SMTP id AA11385
  (5.67b/IDA-1.5 for debian-bugs-done-pipe@mongo.pixar.com); Fri, 13 Oct 1995 09:20:44 -0700
Received: from miles.econ.queensu.ca (free1-slip211.tele.QueensU.CA [130.15.126.211]) by post.QueensU.CA (8.6.12/8.6.10+ASH) with SMTP id MAA20507; Fri, 13 Oct 1995 12:20:34 -0400
Received: by miles.econ.queensu.ca
	id <m0t3mqE-00014zC@miles.econ.queensu.ca>
	(Debian /\oo/\ Smail3.1.29.1 #29.33); Fri, 13 Oct 95 12:20 EDT
Message-Id: <m0t3mqE-00014zC@miles.econ.queensu.ca>
Date: Fri, 13 Oct 95 12:20 EDT
To: Austin Donnelly <and1000@cam.ac.uk>, debian-bugs-done@pixar.com
Subject: Re: Bug#1651: lastcomm has bug with 8 character user names (patch enclosed)
In-Reply-To: <Pine.SOL.3.91.951012160120.23262A-100000@hammer.thor.cam.ac.uk>
References: <Pine.SOL.3.91.951012160120.23262A-100000@hammer.thor.cam.ac.uk>
From: Dirk.Eddelbuettel@qed.econ.queensu.ca


Fixed in acct-5-12.deb. Thanks for the patch!

-- 
Dirk.Eddelbuettel@qed.econ.queensu.ca          http://qed.econ.queensu.ca/~edd 

Message received at debian-bugs:

From thor.cam.ac.uk!and1000 Thu Oct 12 08:06:13 1995
Return-Path: <and1000@thor.cam.ac.uk>
Received: from pixar.com by mongo.pixar.com with smtp
	(Smail3.1.28.1 #15) id m0t3PCy-00062rC; Thu, 12 Oct 95 08:06 PDT
Received: from hammer.thor.cam.ac.uk by pixar.com with SMTP id AA13908
  (5.67b/IDA-1.5 for debian-bugs-pipe@mongo.pixar.com); Thu, 12 Oct 1995 08:05:46 -0700
Received: by hammer.thor.cam.ac.uk 
	(Smail-3.1.29.0 #77) id m0t3PCS-000JfBC; Thu, 12 Oct 95 16:05 BST
Sender: and1000@thor.cam.ac.uk (Austin Donnelly)
Date: Thu, 12 Oct 1995 16:05:36 +0100 (BST)
From: Austin Donnelly <and1000@cam.ac.uk>
X-Sender: and1000@hammer.thor.cam.ac.uk
To: debian-bugs@pixar.com
Subject: lastcomm has bug with 8 character user names (patch enclosed)
Message-Id: <Pine.SOL.3.91.951012160120.23262A-100000@hammer.thor.cam.ac.uk>
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII


Package: acct
Version: 5-10


The command:

lastcomm <username>

should print entries for only that username.  But if <username> is 8
characters long, then no entries are printed at all.

This is due to a bug, where the array to hold the username is defined
to be 8 chars long, but this is ignoring the need for a trailing '\0'.

This bugfix should be forwarded to the GNU people, in my opinion.

I append my patch below.

Austin


--- uid_hash.h.old	Thu Oct 12 15:59:27 1995
+++ uid_hash.h	Thu Oct 12 15:59:36 1995
@@ -3,7 +3,7 @@
  * ... duh ...
  */
 
-#define NAME_LEN 8		/* length for usernames & devices */
+#define NAME_LEN 9		/* length for usernames & devices */
 #define TABLE_SIZE 51		/* nice prime table length */
 
 struct uid_entry {