Debian bug report logs - #1651, boring messages

Subject: Bug#1651: lastcomm has bug with 8 character user names (patch enclosed)
Reply-To: Austin Donnelly <and1000@cam.ac.uk>, debian-bugs@pixar.com
Resent-From: Austin Donnelly <and1000@cam.ac.uk>
Orignal-Sender: and1000@thor.cam.ac.uk (Austin Donnelly)
Resent-To: debian-devel@pixar.com
Resent-Date: Thu, 12 Oct 1995 15:18:02 GMT
Resent-Message-ID: <debian-bugs-handler.1651.B10121507510@pixar.com>
Resent-Sender: iwj10@cus.cam.ac.uk
X-Debian-PR-Package: acct
X-Debian-PR-Keywords: 
Received: via spool for debian-bugs; Thu, 12 Oct 1995 15:18:02 GMT
Received: with rfc822 via encapsulated-mail; Thu, 12 Oct 1995 15:07:49 GMT
Received: from pixar.com by mongo.pixar.com with smtp
	(Smail3.1.28.1 #15) id m0t3PCy-00062rC; Thu, 12 Oct 95 08:06 PDT
Received: from hammer.thor.cam.ac.uk by pixar.com with SMTP id AA13908
  (5.67b/IDA-1.5 for debian-bugs-pipe@mongo.pixar.com); Thu, 12 Oct 1995 08:05:46 -0700
Received: by hammer.thor.cam.ac.uk
	(Smail-3.1.29.0 #77) id m0t3PCS-000JfBC; Thu, 12 Oct 95 16:05 BST
Sender: and1000@thor.cam.ac.uk (Austin Donnelly)
Date: Thu, 12 Oct 1995 16:05:36 +0100 (BST)
From: Austin Donnelly <and1000@cam.ac.uk>
X-Sender: and1000@hammer.thor.cam.ac.uk
To: debian-bugs@pixar.com
Message-Id: <Pine.SOL.3.91.951012160120.23262A-100000@hammer.thor.cam.ac.uk>
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII


Package: acct
Version: 5-10


The command:

lastcomm <username>

should print entries for only that username.  But if <username> is 8
characters long, then no entries are printed at all.

This is due to a bug, where the array to hold the username is defined
to be 8 chars long, but this is ignoring the need for a trailing '\0'.

This bugfix should be forwarded to the GNU people, in my opinion.

I append my patch below.

Austin


--- uid_hash.h.old	Thu Oct 12 15:59:27 1995
+++ uid_hash.h	Thu Oct 12 15:59:36 1995
@@ -3,7 +3,7 @@
  * ... duh ...
  */

-#define NAME_LEN 8		/* length for usernames & devices */
+#define NAME_LEN 9		/* length for usernames & devices */
 #define TABLE_SIZE 51		/* nice prime table length */

 struct uid_entry {

From: iwj10@thor.cam.ac.uk (Ian Jackson)
To: Austin Donnelly <and1000@cam.ac.uk>
Subject: Bug#1651: Acknowledgement (was: lastcomm has bug with 8 character user names (patch enclosed))
In-Reply-To: <Pine.SOL.3.91.951012160120.23262A-100000@hammer.thor.cam.ac.uk>
References: <Pine.SOL.3.91.951012160120.23262A-100000@hammer.thor.cam.ac.uk>

Thank you for the problem report you have sent regarding Debian GNU/Linux.
This is an automatically generated reply, to let you know your message has
been received.  It is being forwarded to the developers' mailing list for
their attention; they will reply in due course.

If you wish to submit further information on your problem, please send
it to debian-bugs@pixar.com, but please ensure that the Subject
line of your message starts with "Bug#1651" or "Re: Bug#1651" so that
we can identify it as relating to the same problem.

Please do not reply to the address at the top of this message,
unless you wish to report a problem with the bug-tracking system.

Ian Jackson
(maintainer, debian-bugs)

From: iwj10@thor.cam.ac.uk (Ian Jackson)
To: Dirk.Eddelbuettel@qed.econ.queensu.ca
In-Reply-To: <m0t3mqE-00014zC@miles.econ.queensu.ca>
References: <m0t3mqE-00014zC@miles.econ.queensu.ca> <Pine.SOL.3.91.951012160120.23262A-100000@hammer.thor.cam.ac.uk>
Subject: Bug#1651: marked as done (was: lastcomm has bug with 8 character user names (patch enclosed))

Your message dated Fri, 13 Oct 95 12:20 EDT
with message-id <m0t3mqE-00014zC@miles.econ.queensu.ca>
and subject line Bug#1651: lastcomm has bug with 8 character user names (patch enclosed)
has caused the attached bug report to be marked as done.

It is your now responsibility to ensure that the bug report is dealt
with.

(NB: If you are a system administrator and have no idea what I'm
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Ian Jackson
(maintainer, debian-bugs)

Received: with rfc822 via encapsulated-mail; Thu, 12 Oct 1995 15:07:49 GMT
From thor.cam.ac.uk!and1000 Thu Oct 12 08:06:13 1995
Return-Path: <and1000@thor.cam.ac.uk>
Received: from pixar.com by mongo.pixar.com with smtp
	(Smail3.1.28.1 #15) id m0t3PCy-00062rC; Thu, 12 Oct 95 08:06 PDT
Received: from hammer.thor.cam.ac.uk by pixar.com with SMTP id AA13908
  (5.67b/IDA-1.5 for debian-bugs-pipe@mongo.pixar.com); Thu, 12 Oct 1995 08:05:46 -0700
Received: by hammer.thor.cam.ac.uk
	(Smail-3.1.29.0 #77) id m0t3PCS-000JfBC; Thu, 12 Oct 95 16:05 BST
Sender: and1000@thor.cam.ac.uk (Austin Donnelly)
Date: Thu, 12 Oct 1995 16:05:36 +0100 (BST)
From: Austin Donnelly <and1000@cam.ac.uk>
X-Sender: and1000@hammer.thor.cam.ac.uk
To: debian-bugs@pixar.com
Subject: lastcomm has bug with 8 character user names (patch enclosed)
Message-Id: <Pine.SOL.3.91.951012160120.23262A-100000@hammer.thor.cam.ac.uk>
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII


Package: acct
Version: 5-10


The command:

lastcomm <username>

should print entries for only that username.  But if <username> is 8
characters long, then no entries are printed at all.

This is due to a bug, where the array to hold the username is defined
to be 8 chars long, but this is ignoring the need for a trailing '\0'.

This bugfix should be forwarded to the GNU people, in my opinion.

I append my patch below.

Austin


--- uid_hash.h.old	Thu Oct 12 15:59:27 1995
+++ uid_hash.h	Thu Oct 12 15:59:36 1995
@@ -3,7 +3,7 @@
  * ... duh ...
  */

-#define NAME_LEN 8		/* length for usernames & devices */
+#define NAME_LEN 9		/* length for usernames & devices */
 #define TABLE_SIZE 51		/* nice prime table length */

 struct uid_entry {

From: iwj10@thor.cam.ac.uk (Ian Jackson)
To: Austin Donnelly <and1000@cam.ac.uk>
Subject: Bug#1651 acknowledged by developer (was: lastcomm has bug with 8 character user names (patch enclosed))
References: <m0t3mqE-00014zC@miles.econ.queensu.ca> <Pine.SOL.3.91.951012160120.23262A-100000@hammer.thor.cam.ac.uk>
In-Reply-To: <Pine.SOL.3.91.951012160120.23262A-100000@hammer.thor.cam.ac.uk>

This is an automatic notification regarding your bug report.

Responsibility for it has been taken by one of the developers, namely
Dirk.Eddelbuettel@qed.econ.queensu.ca.

You should be hearing from them with a substantive response shortly, if
you have not already done so.  If not, please contact them directly,
or email debian-bugs@pixar.com or myself.

Ian Jackson
(maintainer, debian-bugs)