Debian bug report logs - #1354
bigloo: several problems (ELF, packaging, manpage)

Message received at debian-bugs:

From irz301.inf.tu-dresden.de!sr1 Mon Oct 30 15:16:49 1995
Return-Path: <sr1@irz301.inf.tu-dresden.de>
Received: from pixar.com by mongo.pixar.com with smtp
	(Smail3.1.28.1 #15) id m0tA3Rg-000C0WC; Mon, 30 Oct 95 15:16 PST
Received: from irz101.inf.tu-dresden.de by pixar.com with SMTP id AA21362
  (5.67b/IDA-1.5 for debian-bugs-pipe@mongo.pixar.com); Mon, 30 Oct 1995 15:16:16 -0800
Received: by irz101.inf.tu-dresden.de (8.6.12/8.6.12-s1) id AAA21785; Tue, 31 Oct 1995 00:16:39 +0100
Date: Tue, 31 Oct 1995 00:16:39 +0100
From: sr1@irz301.inf.tu-dresden.de (Sven Rudolph)
Message-Id: <199510302316.AAA21785@irz101.inf.tu-dresden.de>
To: debian-bugs@Pixar.com
X-Debian-Pr: quiet
In-Reply-To: jdassen@WI.LeidenUniv.NL's message of Tue, 12 Sep 1995 12:27:15 +0200 (MDT)
Subject: Re: Bug#1354: bigloo: several problems (ELF, packaging, manpage)
References: <199509121027.KAA26520@ind206aa.wi.leidenuniv.nl>

In article <199509121027.KAA26520@ind206aa.wi.leidenuniv.nl> jdassen@WI.LeidenUniv.NL (J.H.M.Dassen) writes:

I corrected the listed bugs, but there appeared new problems wrt ELF.

Therefore I do not close the bug.
 
	Sven
-- 
Sven Rudolph (sr1@inf.tu-dresden.de); WWW : http://www.sax.de/~sr1/

Message received at debian-bugs:

From WI.LeidenUniv.NL!jdassen Tue Sep 12 03:27:49 1995
Return-Path: <jdassen@WI.LeidenUniv.NL>
Received: from pixar.com by mongo.pixar.com with smtp
	(Smail3.1.28.1 #15) id m0ssSYz-0006dRC; Tue, 12 Sep 95 03:27 PDT
Received: from mailhost.WI.LeidenUniv.NL (zeus128.wi.leidenuniv.nl) by pixar.com with SMTP id AA01380
  (5.67b/IDA-1.5 for debian-bugs-pipe@mongo.pixar.com); Tue, 12 Sep 1995 03:27:19 -0700
Received: from ind206aa.wi.leidenuniv.nl (jdassen@ind206aa [132.229.128.222])
          by mailhost.WI.LeidenUniv.NL (8.6.10a/FHM-1.20-M) with ESMTP id MAA19432
          Tue, 12 Sep 1995 12:27:18 +0200 (MET)
From: jdassen@WI.LeidenUniv.NL (J.H.M.Dassen)
Organization: Leiden University,
              Dept. of Mathematics & Computer Science,
              The Netherlands
Received: from  (jdassen@localhost)
          by ind206aa.wi.leidenuniv.nl (8.6.9/FHM-1.03-S) id KAA26520
          Tue, 12 Sep 1995 10:27:16 GMT (MET)
Message-Id: <199509121027.KAA26520@ind206aa.wi.leidenuniv.nl>
Subject: bigloo: several problems (ELF, packaging, manpage)
To: debian-bugs@pixar.com, sr1@inf.tu-dresden.de (Sven Rudolph)
Date: Tue, 12 Sep 1995 12:27:15 +0200 (MDT)
Return-Receipt-To: jdassen@WI.LeidenUniv.NL
X-Home-Page: <URL:http://www.wi.leidenuniv.nl/home/jdassen>
X-Mailer: ELM [version 2.4 PL24 (modified)]
Content-Type: text
Content-Length: 3930      

Package: bigloo
Version: 1.7b-2

1. Problem noted when compiling using elf-libc 5.0.9-2.

   The following piece of code appears in distribution/bigloo.h.tail, 
   and is therefore included in distribution/bigloo.h and in lib/1.7/bigloo.h:
--
#if( !defined( __alpha ) )
extern int toupper(), tolower();
#endif
--

  This breaks ELF compiles, since toupper and tolower are actually
  macros calling internal functions in the ELF <ctype.h>.
  <ctype.h> is the standard location for toupper and tolower 
  (according to appendix B of Kernighan & Ritchie, 2nd edition).

  Solution: replace the aforementioned code with
--
#include <ctype.h>
--
  (Perhaps the #ifndef __alpha is still needed, although I can't imagine
  why).

  Declaring library functions extern instead of including appropriate 
  headers is a Bad Thing.


2. The Makefile starts several "make"s in a subshell (parentheses
   construction), without doing a subsequent "|| exit 1". 
   Errors in sub-makes therefore do not necessarily cause errors
   in the top make. A compile can therefore look like it succeeded
   ("make gave no error"), while in fact it went wrong.
   A result of this is that "debian.rules binary" can produce an invalid
   debian package.


3. The Makefile uses the "@" construction to suppress command echoing.
   This can cause much confusion.


4. Nitpicking: small manpage fixes.
   Can a native speaker go over these fixes and the manpage please? 
   Some words ("genericity") and constructions ring alarm bells with me, 
   but I can't be sure if they are errors.

-- cut me --
--- documentation/bigloo.1.orig	Mon Sep 11 21:39:05 1995
+++ documentation/bigloo.1	Mon Sep 11 22:03:00 1995
@@ -60,13 +60,13 @@
 Do not load an init file.
 .TP
 .B -s
-compile silently. Print only warning and error messages.
+Compile silently. Print only warning and error messages.
 .TP
 .B -v
-be verbose, print some compilation information.
+Be verbose, print some compilation information.
 .TP
 .B -i
-interprete rather than compile the \fIinput\fR. If no input file is
+Interpret rather than compile the \fIinput\fR. If no input file is
 specified then enter the read-eval-print loop.
 .TP
 .B -E
@@ -98,9 +98,9 @@
 Produce some debug information for \fI.o\fR file.
 .TP
 .B -unsafe[\fIatrsv\fR]
-The compiler produces `runtime safe test' to ensure the safety of the
-executable. It's possible to suppress several or all this runtime test.
--unsafe suppress all of it. Here are the meaning of the partial flags:
+The compiler produces `runtime safe tests' to ensure the safety of the
+executable. It's possible to suppress several or all of these runtime tests.
+-unsafe suppress all of them. Here are the meanings of the partial flags:
 .RS
 .RS
 .TP
@@ -120,7 +120,7 @@
 .TP
 .B s
 Don't check that an object is a well tagged structure before accessing
-to a field. This option is a specialisation of the -t flag.
+a field. This option is a specialisation of the -t flag.
 .TP
 .B v
 Don't check version soundness.
@@ -182,7 +182,7 @@
 but they are not. If you want `call/cc' use this option.
 .TP
 .B -mklib
-Use the compiler to compile the bigloo's librarie. This needs a compilation
+Use the compiler to compile the bigloo's library. This needs a compilation
 special mode.
 .TP
 .B -mkheap
@@ -220,7 +220,7 @@
 Set the environment size (in megabytes). The default value is 4.
 .TP 16
 .B BIGLOOLIB
-The path to find the Bigloo's librarie.
+The path to find the Bigloo's library.
 .TP 16
 .B BIGLOOINCLUDE
 The path to find the Bigloo's include.
-- ouch --


Please go over these problems/suggestions, and pass them on to the
upstream maintainer if they are considered valid.

Ray
-- 
PATRIOTISM  A great British writer once said that if he had to choose 
between betraying his country and betraying a friend he hoped he would
have the decency to betray his country.                                      
- The Hipcrime Vocab by Chad C. Mulligan