Debian bug report logs - #1336
CFLAGS shouldn't be used when linking

Message received at debian-bugs:

From cus.cam.ac.uk!iwj10 Sat Sep  9 18:03:46 1995
Return-Path: <iwj10@cus.cam.ac.uk>
Received: from pixar.com by mongo.pixar.com with smtp
	(Smail3.1.28.1 #15) id m0sraoD-000EtEC; Sat, 9 Sep 95 18:03 PDT
Received: from bootes.cus.cam.ac.uk by pixar.com with SMTP id AA27106
  (5.67b/IDA-1.5 for debian-bugs-pipe@mongo.pixar.com); Sat, 9 Sep 1995 18:03:31 -0700
Received: by bootes.cus.cam.ac.uk 
	(Smail-3.1.29.0 #36) id m0sranB-000BzUC; Sun, 10 Sep 95 02:02 BST
Received: by chiark
	id <m0srVmy-0002ZbZ@chiark.al.cl.cam.ac.uk>
	(Debian /\oo/\ Smail3.1.29.1 #29.33); Sat, 9 Sep 95 20:42 BST
Message-Id: <m0srVmy-0002ZbZ@chiark.al.cl.cam.ac.uk>
Date: Sat, 9 Sep 95 20:42 BST
From: Ian Jackson <iwj10@cus.cam.ac.uk>
To: Herbert Xu <herbert@greathan.apana.org.au>, debian-bugs@pixar.com
Subject: Re: Bug#1336: CFLAGS shouldn't be used when linking

Herbert Xu writes ("Bug#1336: CFLAGS shouldn't be used when linking"):
> Package: procps
> Version: 0.97-4
> 
> In the Makefile, CFLAGS were used when linking the various object
> files.  This shouldn't be the case and it would cause problems when
> one wishes to compile the source code with '-g' but not to link it
> with '-g'.

This is not a bug.  Package maintainers are free to do whatever they
want in their Makefiles (frequently they don't have any control over
them).

> Here is a patch that fixes the problem:

The patch is probably undesirable.  It will mean that every time the
procps upstream package Makefile changes we'll have a rejected patch
for the Debianisation.

I'm not closing this report because the package maintainer may want to
take some of your comments on board, or forward them to the upstream
maintainer.

Ian.

Message received at debian-bugs:

From ion.apana.org.au!greathan.apana.org.au!herbert Sat Sep  9 01:09:47 1995
Return-Path: <greathan.apana.org.au!herbert@ion.apana.org.au>
Received: from pixar.com by mongo.pixar.com with smtp
	(Smail3.1.28.1 #15) id m0srKyv-0002NgC; Sat, 9 Sep 95 01:09 PDT
Received: from ion.apana.org.au by pixar.com with SMTP id AA04596
  (5.67b/IDA-1.5 for debian-bugs-pipe@mongo.pixar.com); Sat, 9 Sep 1995 01:09:25 -0700
Received: (from herbert@localhost) by greathan.apana.org.au (8.6.12/8.6.6) id RAA31560 for debian-bugs@pixar.com; Sat, 9 Sep 1995 17:53:10 +1000
From: Herbert Xu <herbert@greathan.apana.org.au>
Message-Id: <199509090753.RAA31560@greathan.apana.org.au>
Subject: CFLAGS shouldn't be used when linking
To: debian-bugs@pixar.com
Date: Sat, 9 Sep 1995 17:53:02 +1000 (EST)
X-Mailer: ELM [version 2.4 PL24 PGP2]
Content-Type: text
Content-Length: 2702      

Package: procps
Version: 0.97-4

In the Makefile, CFLAGS were used when linking the various object
files.  This shouldn't be the case and it would cause problems when
one wishes to compile the source code with '-g' but not to link it
with '-g'.

Here is a patch that fixes the problem:

PS It might be desirable to define SLDFLAGS in terms of LDFLAGS.

--- procps-0.97/Makefile.orig	Sat Sep  9 16:15:42 1995
+++ procps-0.97/Makefile	Sat Sep  9 16:17:08 1995
@@ -53,7 +53,7 @@
 	$(CC) $(CFLAGS) $(TTY_FULL_DEVNO) -c snap.c
 
 ps:	$(liba) ps.o
-	$(CC) $(CFLAGS) $(LDFLAGS) -o ps ps.o -L. -l$(lib) $(LIBS)
+	$(CC) $(LDFLAGS) -o ps ps.o -L. -l$(lib) $(LIBS)
 
 #w.o:	w.c ps.h whattime.h
 #	$(CC) $(CFLAGS) $(W_SHOWFROM) -c w.c $(LIBS)
@@ -65,40 +65,40 @@
 	$(CC) $(CFLAGS) -I/usr/include/bsd -c w.c
 
 #w:	$(liba) w.o
-#	$(CC) $(CFLAGS) $(LDFLAGS) -o w w.o -L. -l$(lib) $(LIBS)
+#	$(CC) $(LDFLAGS) -o w w.o -L. -l$(lib) $(LIBS)
 
 w:	w.o attime.o
-	$(CC) $(CFLAGS) $(LDFLAGS) -o w w.o attime.o -lbsd
+	$(CC) $(LDFLAGS) -o w w.o attime.o -lbsd
 
 psupdate:	$(liba) psupdate.o
-	$(CC) $(CFLAGS) $(SLDFLAGS) -o psupdate psupdate.o -L. -l$(lib) $(LIBS)
+	$(CC) $(SLDFLAGS) -o psupdate psupdate.o -L. -l$(lib) $(LIBS)
 
 top:	$(liba) top.o signals.o
-	$(CC) $(CFLAGS) $(LDFLAGS) -o top top.o signals.o -ltermcap -L. -l$(lib) $(LIBS)
+	$(CC) $(LDFLAGS) -o top top.o signals.o -ltermcap -L. -l$(lib) $(LIBS)
 
 uptime:	$(liba) uptime.o
-	$(CC) $(CFLAGS) $(SLDFLAGS) uptime.o -o uptime -L. -l$(lib) $(LIBS)
+	$(CC) $(SLDFLAGS) uptime.o -o uptime -L. -l$(lib) $(LIBS)
 
 tload:	$(liba) tload.o
-	$(CC) $(CFLAGS) $(SLDFLAGS) tload.o -o tload -L. -l$(lib) $(LIBS)
+	$(CC) $(SLDFLAGS) tload.o -o tload -L. -l$(lib) $(LIBS)
 
 free:	free.o
-	$(CC) $(CFLAGS) $(SLDFLAGS) free.o -o free $(LIBS)
+	$(CC) $(SLDFLAGS) free.o -o free $(LIBS)
 
 utmp:	utmp.o
-	$(CC) $(CFLAGS) $(LDFLAGS) utmp.o -o utmp $(LIBS)
+	$(CC) $(LDFLAGS) utmp.o -o utmp $(LIBS)
 
 fuser:	fuser.o signals.o
-	$(CC) $(CFLAGS) $(SLDFLAGS) fuser.o signals.o -o fuser $(LIBS)
+	$(CC) $(SLDFLAGS) fuser.o signals.o -o fuser $(LIBS)
 
 killall: killall.o signals.o
-	$(CC) $(CFLAGS) $(SLDFLAGS) killall.o signals.o -o killall $(LIBS)
+	$(CC) $(SLDFLAGS) killall.o signals.o -o killall $(LIBS)
 
 pstree:	pstree.o
-	$(CC) $(CFLAGS) $(SLDFLAGS) -o pstree pstree.o -ltermcap $(LIBS)
+	$(CC) $(SLDFLAGS) -o pstree pstree.o -ltermcap $(LIBS)
 
 vmstat: vmstat.o
-	$(CC) $(CFLAGS) $(SLDFLAGS) -o vmstat vmstat.o $(LIBS)
+	$(CC) $(SLDFLAGS) -o vmstat vmstat.o $(LIBS)
 
 
 xproc/Makefile: xproc/Imakefile
-- 
A.  B <=> True			B.  A <=> False
Email:  Herbert Xu ~{PmV>HI~} <herbert@greathan.apana.org.au>
PGP Key:  pgp-public-keys@pgp.mit.edu or any other key sites