 4-Sep-85 02:06:28-MDT,971;000000000001
Return-Path: <unix-sources-request@BRL.ARPA>
Received: from BRL-TGR.ARPA by SIMTEL20.ARPA with TCP; Wed 4 Sep 85 02:06:25-MDT
Received: from usenet by TGR.BRL.ARPA id a004625; 3 Sep 85 23:57 EDT
From: Chris Torek <chris@umcp-cs.uucp>
Newsgroups: net.sources.bugs
Subject: Re: DHU-11 driver for 4.2BSD
Message-ID: <1470@umcp-cs.UUCP>
Date: 4 Sep 85 01:16:25 GMT
Keywords: DHU-11 4.2BSD
To:       unix-sources-bugs@BRL-TGR.ARPA

Two quick things I noticed:

If you want this to coexist with a dh, change

	int cbase[MAXNUBA];

to

	static int cbase[MAXNUBA];

Also, you have propagated a bug from the dh driver; dhuioctl
should check

		if (cmd == TIOCSETP || cmd == TIOCSETN || cmd == TIOCLSET ||
		    cmd == TIOCLBIS || cmd == TIOCLBIC)

instead of just the first two, before calling dhuparam.
-- 
In-Real-Life: Chris Torek, Univ of MD Comp Sci Dept (+1 301 454 4251)
UUCP:	seismo!umcp-cs!chris
CSNet:	chris@umcp-cs		ARPA:	chris@maryland
